Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnits expectExceptionMessageRegExp becomes deprecated in Phpunit 9 #3626

Closed
wants to merge 1 commit into from
Closed

PHPUnits expectExceptionMessageRegExp becomes deprecated in Phpunit 9 #3626

wants to merge 1 commit into from

Conversation

wRLSS
Copy link

@wRLSS wRLSS commented Jun 30, 2020

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tickets -//-
License MIT
Doc PR -//-

PHPUnit expectExceptionMessageRegExp becomes deprecated in PHPUnit 9, we should promote expectExceptionMessageMatches instead.

…, promote `expectExceptionMessageMatches` instead.
@wRLSS wRLSS changed the base branch from master to 2.5 June 30, 2020 13:49
@wRLSS wRLSS changed the base branch from 2.5 to master June 30, 2020 13:50
@dunglas
Copy link
Member

dunglas commented Jul 10, 2020

It looks like it breaks our test suite. You should probably bump the minimum version of symfony/phpunit-bridge to be sure that symfony/symfony#36408 is installed even when using composer --prefer-lowest.

@dunglas
Copy link
Member

dunglas commented Aug 27, 2020

Will be fixed by #3688

@dunglas dunglas closed this Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants